Thanks for adding support for hiding the controls when video is playing. "Almost there!"
I have two ICS devices and they behave differently and could use improvement:
1) Galaxy Nexus ICS 4.0.4 - Stock rom
When video starts, it goes full screen and hides controls as expected. Nice. :)
Tapping on the video gives me the android controls (back, home, menu)
Tapping again on the video gives me playback controls
Tapping third time dismisses both and goes back to full screen
I would argue that only 1 tap should be needed and both sets of controls should be shown.
2) HP Touchpad running ICS CM9 nightly
The screen isn't 16x9, so when the video goes full screen there are black bars on the top and bottom as expected and the soft android buttons reduce to dots and the status goes away. Nice.
tapping on the video gives me both sets of controls (as I'd want). There is enough vertical space that the controls can show without having to shrink the video.
The problem I see is that the bottom "black bar" is really a dark grey bar. I think this is the background for the media controls. The controls are hidden, but the background is not.
Hopefully these little issues can be fixed with small tweaks.
I've got an issue created for the first issue, I'm seeing the same thing on my gnexus...that's a bug that should be fixed.
I'm not sure what I can do about the second. We are using an android video player for video playback and I think what you are describing is happening within the player. That may be a problem with the ROM.
Is anyone else seeing the second issue on a device with a stock rom?
Thanks for posting.
I've uploaded some screen shots to show what I see on the HP Touchpad with CM9. I've also uploaded the same from the external (system) player. BTW: I like the look of the slider in the external player much more than DC's. Seems to be the direction ICS is going with the controls.
You can see, even with the controls up on the internal player that there is a sliver of grey above the controls but below the video.
Internal player with controls:
https://picasaweb.google.com/100805137576379989708/61812#575542391667663...
Internal player without controls:
https://picasaweb.google.com/100805137576379989708/20120618#575542181178...
External player with controls:
https://picasaweb.google.com/100805137576379989708/6181203#5755424249652...
External player without controls:
https://picasaweb.google.com/100805137576379989708/6181202#5755424114860...
Ok, thanks for the details. I see what you're talking about now. I'm not sure I'll be able to fix it without being able to reproduce on a device but I'll give it a shot.
I created an issue for this - http://mantis.snoggdoggler.com/view.php?id=1402
Thanks.